Skip to content

Add test to check mismatching zend_func_info entries #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add test to check mismatching zend_func_info entries #5666

wants to merge 2 commits into from

Conversation

kocsismate
Copy link
Member

No description provided.

nikic
nikic reviewed Jun 5, 2020
View reviewed changes
nikic
nikic reviewed Jun 5, 2020
View reviewed changes
kocsismate
kocsismate commented Jun 5, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the func-info-test branch 2 times, most recently from f2e0b2a to bc6860a Compare June 5, 2020 13:20
nikic
nikic approved these changes Jun 5, 2020
View reviewed changes
@nikic
Copy link
Member

nikic commented Jun 5, 2020

CI failure:

Fatal error: Arginfo / zpp mismatch during call of intlcal_roll() in Unknown on line 0

@kocsismate
Copy link
Member Author

kocsismate commented Jun 5, 2020 •
edited
Loading

@nikic Would it make sense to change the 3rd param type of intlcal_roll() to int? If not, then I'll just fix the ZPP issue.

UPDATE: Now I see that co->ucal->roll() is called differently based on this type so I won't change this.

kocsismate
kocsismate commented Jun 5, 2020
View reviewed changes
@php-pulls php-pulls closed this in aa9b0cc Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @nikic @Girgias