Add warning for arguments in stubs that doesn't have any type info #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
May 26, 2020
kocsismate
commented
May 26, 2020
kocsismate
force-pushed
the
stub-param-type-warning
branch
from
549ce7c to
a9f4970
Compare
kocsismate
commented
May 26, 2020
nikic
reviewed
Jun 3, 2020
kocsismate
force-pushed
the
stub-param-type-warning
branch
from
c53fe7c to
73ee69f
Compare
nikic
reviewed
Jul 10, 2020
nikic
reviewed
Jul 10, 2020
nikic
reviewed
Jul 10, 2020
kocsismate
force-pushed
the
stub-param-type-warning
branch
from
73ee69f to
b5fdec2
Compare
kocsismate
commented
Jul 29, 2020
kocsismate
force-pushed
the
stub-param-type-warning
branch
from
b5fdec2 to
215e50d
Compare
nikic
reviewed
Jul 29, 2020
nikic
reviewed
Jul 29, 2020
nikic
approved these changes
Jul 30, 2020
php-pulls
pushed a commit
that referenced
this pull request
Jul 30, 2020
kocsismate
force-pushed
the
stub-param-type-warning
branch
from
ae4b6b5 to
64058f5
Compare
|
How many warnings do we have after the last two PRs? |
|
@nikic Only 60! :) And I'm already working on the next batch. If there's no need to write too much code, I'll create a single PR for all. |
|
I'm wondering how to proceed now that we'll soon have all the missing types. Can we throw an exception instead of the warning? I'm asking this because even though it would be no longer a problem for php-src, but there might be extensions which need a bit more permissiveness. |
kocsismate
force-pushed
the
stub-param-type-warning
branch
from
64058f5 to
86a9a63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.