Fix default sendmail path when not found during build #5548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
May 9, 2020
| #else | ||
| # define DEFAULT_SENDMAIL_PATH "/usr/sbin/sendmail -t -i" | ||
| # define DEFAULT_SENDMAIL_PATH PHP_PROG_SENDMAIL " -t -i" |
There was a problem hiding this comment.
This line is now the same as in the above elif branch?
There was a problem hiding this comment.
Correct, since PHP_PROG_SENDMAIL is always defined.
nikic
approved these changes
May 11, 2020
|
It would be better to find the sendmail binary in PATH at runtime, but this is clearly better than what it does now... |
chrismshelton
added a commit
to LastCallMedia/PHP-Docker
that referenced
this pull request
Aug 23, 2022
petk
added a commit
to petk/php-src
that referenced
this pull request
Jul 14, 2024
The sendmail is set to default value of /usr/sbin/sendmail if not found on the host system. This was already properly fixed via phpGH-5548 (commit 5174318). This change now also outputs "no" when searching for sendmail and a minimalistic notice that default send_mail INI directive has been set to /usr/sbin/sendmail. Fixes and closes: https://bugs.php.net/78757
petk
added a commit
that referenced
this pull request
Jul 14, 2024
The sendmail is set to default value of /usr/sbin/sendmail if not found on the host system. This was already properly fixed via GH-5548 (commit 5174318). This change now also outputs "no" when searching for sendmail and a minimalistic notice that default send_mail INI directive has been set to /usr/sbin/sendmail. Fixes and closes: https://bugs.php.net/78757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix Bug #78757 where the default
sendmail_pathwas not correctly set if it was not found on the system. Without the fix the path to binary would be empty, resulting in not so usefulsendmail_path = -t -iin case sendmail is installed later to the default path.Since
PHP_PROG_SENDMAILis set unconditionally, it made sense to simply fill the fallback value in the autoconf script. However, this approach seems to have a drawback that now the configure script will reportchecking for sendmail... /usr/sbin/sendmailinstead of the previouschecking for sendmail... noif sendmail cannot be found. I'm open to suggestions on how to improve it if needed.