Skip to content

proc_open refactoring (1) #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

proc_open refactoring (1) #5507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3459039
Nothing in proc_open.c needs stat.h
alexdowad May 1, 2020
8a1981d
Introduce set_proc_descriptor_to_blackhole helper in proc_open.c
alexdowad May 1, 2020
838fbc1
Remove unneeded constant DESC_PARENT_MODE_WRITE from proc_open.c
alexdowad May 1, 2020
0a3e051
Code tweaks in proc_open.c
alexdowad May 1, 2020
3bec2e1
Introduce efree_argv helper in proc_open.c
alexdowad May 1, 2020
1a534a2
Introduce get_option helper in proc_open.c
alexdowad May 1, 2020
292efd4
Introduce alloc_descriptor_array helper in proc_open.c
alexdowad May 1, 2020
f242998
Initialize SECURITY_ATTRIBUTES only once in proc_open.c
alexdowad May 1, 2020
a058757
Introduce set_proc_descriptor_to_pipe helper in proc_open.c
alexdowad May 1, 2020
f971744
Introduce init_startup_info helper in proc_open.c
alexdowad May 1, 2020
c8ca391
Introduce close_all_descriptors helper in proc_open.c
alexdowad May 1, 2020
a0a290b
Introduce set_proc_descriptor_to_file helper in proc_open.c
alexdowad May 1, 2020
7484ec4
Introduce convert_command_to_use_shell helper in proc_open.c
alexdowad May 1, 2020
fd524a6
Introduce init_process_info helper in proc_open.c
alexdowad May 1, 2020
6bd6faf
Convert 'mode' member of proc_open_descriptor_item to 'is_pipe'
alexdowad May 1, 2020
14783fe
Introduce close_parent_ends_of_pipes_in_child helper in proc_open.c
alexdowad May 1, 2020
a62699a
Show error in child process if exec fails (in proc_open)
alexdowad May 1, 2020
644a1bc
Simplify code for finding descriptor to redirect to
alexdowad May 1, 2020
6a981a0
Free memory just before returning from proc_open
alexdowad May 1, 2020
fa49945
Introduce dup_proc_descriptor helper in proc_open.c
alexdowad May 1, 2020
8dbf742
Simplify code for handling streams in proc_open
alexdowad May 1, 2020
1b4ac55
Introduce get_string_parameter helper in proc_open.c
alexdowad May 1, 2020
a15dc8d
Introduce get_command_from_array helper in proc_open.c
alexdowad May 1, 2020
3c99c0b
Use zend_string for strings in proc_open
alexdowad May 2, 2020
38b2b0f
Remove long-disabled #defines from proc_open.c
alexdowad May 3, 2020
0f653c6
Introduce redirect_proc_descriptor helper in proc_open.c
alexdowad May 3, 2020
6e1e5c6
Improve error message when FD redirect target for proc_open is non-in…
alexdowad May 3, 2020
c1922e8
Dereference references used in 'other_options' parameter to proc_open
alexdowad May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading