Skip to content

Remove the deprecated is_real() function #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions ext/standard/basic_functions.stub.php
Original file line number Diff line number Diff line change
Expand Up @@ -1438,13 +1438,6 @@ function is_float($value): bool {}
*/
function is_double($value): bool {}

/**
* @param mixed $value
* @alias is_float
* @deprecated
*/
function is_real($value): bool {}

/** @param mixed $value */
function is_numeric($value): bool {}

Expand Down
3 changes: 0 additions & 3 deletions ext/standard/basic_functions_arginfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -2093,8 +2093,6 @@ ZEND_END_ARG_INFO()

#define arginfo_is_double arginfo_boolval

#define arginfo_is_real arginfo_boolval

#define arginfo_is_numeric arginfo_boolval

#define arginfo_is_string arginfo_boolval
Expand Down Expand Up @@ -3454,7 +3452,6 @@ static const zend_function_entry ext_functions[] = {
ZEND_FALIAS(is_long, is_int, arginfo_is_long)
ZEND_FE(is_float, arginfo_is_float)
ZEND_FALIAS(is_double, is_float, arginfo_is_double)
ZEND_FALIAS(is_real, is_float, arginfo_is_real)
ZEND_FE(is_numeric, arginfo_is_numeric)
ZEND_FE(is_string, arginfo_is_string)
ZEND_FE(is_array, arginfo_is_array)
Expand Down
83 changes: 7 additions & 76 deletions ext/standard/tests/general_functions/is_float.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--TEST--
Test is_float() & it's FALIASes: is_double() & is_real() functions
Test is_float() & its is_double() alias
--SKIPIF--
<?php
if (PHP_INT_SIZE != 4) die("skip this test is for 32bit platform only");
Expand All @@ -10,7 +10,7 @@ if (PHP_INT_SIZE != 4) die("skip this test is for 32bit platform only");
* Description: Finds whether the given variable is a float
*/

echo "*** Testing is_float(), is_double() and is_real() with float values***\n";
echo "*** Testing is_float(), is_double() with float values***\n";
// different valid float values
$floats = array(
-2147483649, // float value
Expand Down Expand Up @@ -44,17 +44,16 @@ $floats = array(
.0034E-30,
-.0034E-30
);
/* loop to check that is_float(), is_double() & is_real() recognizes
/* loop to check that is_float(), is_double() & recognizes
different float values, expected: bool(true) */
$loop_counter = 1;
foreach ($floats as $float ) {
echo "-- Iteration $loop_counter --\n"; $loop_counter++;
var_dump( is_float($float) );
var_dump( is_double($float) );
var_dump( @is_real($float) );
}

echo "\n*** Testing is_float(), is_double() & is_real() with non float values ***\n";
echo "\n*** Testing is_float(), is_double() with non float values ***\n";
// get a resource type variable
$fp = fopen (__FILE__, "r");
$dfp = opendir ( __DIR__ );
Expand Down Expand Up @@ -117,14 +116,13 @@ $not_floats = array (
@$undefined_var
);
/* loop through the $not_floats to see working of
is_float(), is_double() & is_real() on objects,
is_float(), is_double() on objects,
arrays, boolean and others */
$loop_counter = 1;
foreach ($not_floats as $value ) {
echo "--Iteration $loop_counter--\n"; $loop_counter++;
var_dump( is_float($value) );
var_dump( is_double($value) );
var_dump( @is_real($value) );
}

echo "Done\n";
Expand All @@ -135,275 +133,208 @@ closedir($dfp);

?>
--EXPECTF--
*** Testing is_float(), is_double() and is_real() with float values***
*** Testing is_float(), is_double() with float values***
-- Iteration 1 --
bool(true)
bool(true)
bool(true)
-- Iteration 2 --
bool(true)
bool(true)
bool(true)
-- Iteration 3 --
bool(true)
bool(true)
bool(true)
-- Iteration 4 --
bool(true)
bool(true)
bool(true)
-- Iteration 5 --
bool(true)
bool(true)
bool(true)
-- Iteration 6 --
bool(true)
bool(true)
bool(true)
-- Iteration 7 --
bool(true)
bool(true)
bool(true)
-- Iteration 8 --
bool(true)
bool(true)
bool(true)
-- Iteration 9 --
bool(true)
bool(true)
bool(true)
-- Iteration 10 --
bool(true)
bool(true)
bool(true)
-- Iteration 11 --
bool(true)
bool(true)
bool(true)
-- Iteration 12 --
bool(true)
bool(true)
bool(true)
-- Iteration 13 --
bool(true)
bool(true)
bool(true)
-- Iteration 14 --
bool(true)
bool(true)
bool(true)
-- Iteration 15 --
bool(true)
bool(true)
bool(true)
-- Iteration 16 --
bool(true)
bool(true)
bool(true)
-- Iteration 17 --
bool(true)
bool(true)
bool(true)
-- Iteration 18 --
bool(true)
bool(true)
bool(true)
-- Iteration 19 --
bool(true)
bool(true)
bool(true)
-- Iteration 20 --
bool(true)
bool(true)
bool(true)
-- Iteration 21 --
bool(true)
bool(true)
bool(true)
-- Iteration 22 --
bool(true)
bool(true)
bool(true)
-- Iteration 23 --
bool(true)
bool(true)
bool(true)
-- Iteration 24 --
bool(true)
bool(true)
bool(true)
-- Iteration 25 --
bool(true)
bool(true)
bool(true)
-- Iteration 26 --
bool(true)
bool(true)
bool(true)
-- Iteration 27 --
bool(true)
bool(true)
bool(true)
-- Iteration 28 --
bool(true)
bool(true)
bool(true)
-- Iteration 29 --
bool(true)
bool(true)
bool(true)
-- Iteration 30 --
bool(true)
bool(true)
bool(true)

*** Testing is_float(), is_double() & is_real() with non float values ***
*** Testing is_float(), is_double() with non float values ***
--Iteration 1--
bool(false)
bool(false)
bool(false)
--Iteration 2--
bool(false)
bool(false)
bool(false)
--Iteration 3--
bool(false)
bool(false)
bool(false)
--Iteration 4--
bool(false)
bool(false)
bool(false)
--Iteration 5--
bool(false)
bool(false)
bool(false)
--Iteration 6--
bool(false)
bool(false)
bool(false)
--Iteration 7--
bool(false)
bool(false)
bool(false)
--Iteration 8--
bool(false)
bool(false)
bool(false)
--Iteration 9--
bool(false)
bool(false)
bool(false)
--Iteration 10--
bool(false)
bool(false)
bool(false)
--Iteration 11--
bool(false)
bool(false)
bool(false)
--Iteration 12--
bool(false)
bool(false)
bool(false)
--Iteration 13--
bool(false)
bool(false)
bool(false)
--Iteration 14--
bool(false)
bool(false)
bool(false)
--Iteration 15--
bool(false)
bool(false)
bool(false)
--Iteration 16--
bool(false)
bool(false)
bool(false)
--Iteration 17--
bool(false)
bool(false)
bool(false)
--Iteration 18--
bool(false)
bool(false)
bool(false)
--Iteration 19--
bool(false)
bool(false)
bool(false)
--Iteration 20--
bool(false)
bool(false)
bool(false)
--Iteration 21--
bool(false)
bool(false)
bool(false)
--Iteration 22--
bool(false)
bool(false)
bool(false)
--Iteration 23--
bool(false)
bool(false)
bool(false)
--Iteration 24--
bool(false)
bool(false)
bool(false)
--Iteration 25--
bool(false)
bool(false)
bool(false)
--Iteration 26--
bool(false)
bool(false)
bool(false)
--Iteration 27--
bool(false)
bool(false)
bool(false)
--Iteration 28--
bool(false)
bool(false)
bool(false)
--Iteration 29--
bool(false)
bool(false)
bool(false)
--Iteration 30--
bool(false)
bool(false)
bool(false)
--Iteration 31--
bool(false)
bool(false)
bool(false)
--Iteration 32--
bool(false)
bool(false)
bool(false)
--Iteration 33--
bool(false)
bool(false)
bool(false)
--Iteration 34--
bool(false)
bool(false)
bool(false)
--Iteration 35--
bool(false)
bool(false)
bool(false)
--Iteration 36--
bool(false)
bool(false)
bool(false)
--Iteration 37--
bool(false)
bool(false)
bool(false)
Done
Loading