Skip to content

Fix #79539: during CI, drop table if it exists #5493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix #79539: during CI, drop table if it exists #5493

wants to merge 1 commit into from

Conversation

elear
Copy link

@elear elear commented Apr 29, 2020

CI fails on mysqli_insert_packet_overflow.phpt based on what mysqli
tests are run, because the test db sometimes lingers. This fix drops
the table if it exists, as most tests do.

CI fails on mysqli_insert_packet_overflow.phpt based on what mysqli
tests are run, because the test db sometimes lingers.  This fix drops
the table if it exists, as most tests do.
@carusogabriel
Copy link
Contributor

This is being discussed in #5479 and #5447 already.

@cmb69
Copy link
Member

cmb69 commented Apr 29, 2020

Thanks for the PR (and for checking AppVeyor CI in the first place)! :)

However, this is indeed a duplicate of PR #5447 (and PR ##5479 has a more comprehensive solution), and we're still hoping to find the root cause of the issue, so deleting the table just before creating it would only be a workaround.

@cmb69 cmb69 closed this Apr 29, 2020
@elear elear deleted the bug-79539 branch April 29, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants