remove deprecated call and deprecate function to be removed in libenc… #5492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this proposal changes, build + test suite are OK using libenchant v1 and libenchant-2 (only need to change config.m4, will submit another PR when this one will be done) |
|
This looks reasonable to me. |
|
Squashed and merged in 66d42e9 |
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Aug 10, 2020
> Deprecate enchant_broker_set_dict_path, enchant_broker_get_dict_path > enchant_dict_add_to_personal and enchant_dict_is_in_session Ref: https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/NEWS#L71 > - enchant_broker_set_dict_path and enchant_broker_get_dict_path > not available in libenchant < 1.5 nor in libenchant-2 > - enchant_dict_add_to_personal, use enchant_dict_add instead > - enchant_dict_is_in_session, use enchant_dict_is_added instead > - enchant_broker_free and enchant_broker_free_dict, unset the object instead Refs: * https://github.com/php/php-src/blob/c0172aa2bdb9ea223c8491bdb300995b93a857a0/UPGRADING#L662-L666 * php/php-src#5492 * php/php-src@66d42e9 * php/php-src#5577 * php/php-src@cd3e04d Includes unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hant v2
Remove deprecated calls
Rename 2 functions to match new upstream and deprecate previous
Deprecate optional functions which will be removed in v 2
Raise dependency on v1.4.2 (May 2008)
all distro seems to have v 1.6 (April 2010)
Add LIBENCHANT_VERSION macro