Make ReflectionProperty and ReflectionMethod access private/protected symbols by default
#5411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otected` symbols by default With this patch, it is no longer required to call `ReflectionProperty#setAccessible()` or `ReflectionMethod#setAccessible()` with `true`. If a userland consumer already got to the point of accessing object/class information via reflection, it makes little sense for `ext/reflection` to disallow accessing `private`/`protected` symbols by default. After this patch, calling `ReflectionProperty#setAccessible(true)` or `ReflectionMethod#setAccessible(true)` on newly instantiated `ReflectionProperty` or `ReflectionMethod` respectively will have no effect.
2 tasks
|
Note: please ignore any failures - local php-src build environment doesn't work for me, so I basically yolo-pushed it to let travis do the hard work for me. |
|
Does it make sense to keep |
|
as discussed in chat, #5412 implements a more aggressive version of this. I plan to open a third PR with a deprecation too. |
|
Do you have any plans to move forward with this change? |
|
I really should work on this, but haven't touched it in a while.
Indeed valuable, will try to allocate time.
…On Wed, Jun 2, 2021, 17:19 Nikita Popov ***@***.***> wrote:
Do you have any plans to move forward with this change?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5411 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEAG72NSLKDKMPMAMGTTQZDYJANCNFSM4MK5DIYA>
.
|
Ocramius
deleted the
feature/make-reflection-property-and-method-accessible-by-default
branch
Ocramius
added a commit
to Ocramius/psalm
that referenced
this pull request
Dec 7, 2022
…rom PHP 8.1 onwards This will highlight unused code. Ref: php/php-src#5412 Ref: https://wiki.php.net/rfc/make-reflection-setaccessible-no-op Ref: php/php-src#5411 Example https://3v4l.org/PNeeZ ```php <?php class Foo { private $bar = 'baz'; private function taz() { return 'waz'; } } //var_dump((new ReflectionProperty(Foo::class, 'bar'))->getValue(new Foo)); //var_dump((new ReflectionMethod(Foo::class, 'taz'))->invoke(new Foo)); ``` Produces (starting from PHP 8.1): ``` string(3) "baz" string(3) "waz" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: pending RFC.
With this patch, it is no longer required to call
ReflectionProperty#setAccessible()orReflectionMethod#setAccessible()withtrue.If a userland consumer already got to the point of accessing object/class information via reflection,
it makes little sense for
ext/reflectionto disallow accessingprivate/protectedsymbols bydefault.
After this patch, calling
ReflectionProperty#setAccessible(true)orReflectionMethod#setAccessible(true)on newly instantiatedReflectionPropertyorReflectionMethodrespectively will have no effect.