Improve some TypeError and ValueError messages #5377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Apr 12, 2020
kocsismate
force-pushed
the
consistent-error-messages4
branch
2 times, most recently
from
3a59ef3 to
696fd3a
Compare
kocsismate
commented
Apr 13, 2020
kocsismate
force-pushed
the
consistent-error-messages4
branch
from
696fd3a to
bf2b3a4
Compare
nikic
reviewed
Apr 14, 2020
kocsismate
force-pushed
the
consistent-error-messages4
branch
from
bf2b3a4 to
2ae901a
Compare
nikic
approved these changes
Apr 14, 2020
alexdowad
reviewed
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR is the last one (at least from me for a while) that improves existing
ValueErrorandTypeErrormessages, since the rest of these error messages seem to be ok(ish).