Generate method entries for ext/dom #5374
Conversation
ext/dom/dom_fe.h
Outdated
| @@ -67,163 +46,4 @@ typedef enum { | |||
| VALIDATION_ERR = 16 | |||
| } dom_exception_code; | |||
There was a problem hiding this comment.
We might want to either move this somewhere else, or rename the file...
There was a problem hiding this comment.
Renamed to domexception.h
ext/dom/php_dom.c
Outdated
| #include "dom_properties.h" | ||
| #include "zend_interfaces.h" | ||
| #if defined(LIBXML_XPATH_ENABLED) | ||
| #include "xpath_arginfo.h" | ||
| #endif |
There was a problem hiding this comment.
I assume xpath is kept separately because the whole class is conditional?
There was a problem hiding this comment.
That's true. Although, I see now (I didn't have the energy to test it yesterday) that only an empty function entry array is left dangling when LIBXML_XPATH_ENABLED is not defined. So should I move DOMXPath to the rest of the stubs?
There was a problem hiding this comment.
Or maybe I could conditionally generate it if it's necessary (by trying to store conditions around classes).
There was a problem hiding this comment.
I'll merge it like this (I moved DOMXPath to the same file where the other stubs are), but I'm happy to iterate on conditional class declaration in a followup PR.
The stub definitions can now be in a single file ^^