Skip to content

Generate method entries for ext/intl #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Generate method entries for ext/intl #5370

wants to merge 2 commits into from

Conversation

kocsismate
Copy link
Member

Unfortunately, the build fails with

Undefined symbols for architecture x86_64:
  "_zim_IntlBreakIterator___construct", referenced from:
      class_IntlBreakIterator_methods in breakiterator_class.o

but I can't imagine what the problem is. Maybe something related to C++?

@nikic
Copy link
Member

nikic commented Apr 12, 2020

Unfortunately, the build fails with

Undefined symbols for architecture x86_64:
  "_zim_IntlBreakIterator___construct", referenced from:
      class_IntlBreakIterator_methods in breakiterator_class.o

but I can't imagine what the problem is. Maybe something related to C++?

Looks like the implementations use the name BreakIterator rather than IntlBreakIterator for the class...

@kocsismate kocsismate force-pushed the method-entries-from-stubs3 branch from 5db416a to d964157 Compare April 12, 2020 11:56
@kocsismate kocsismate force-pushed the method-entries-from-stubs3 branch from d964157 to 9916eeb Compare April 12, 2020 12:04
kocsismate
kocsismate commented Apr 12, 2020
View reviewed changes
@php-pulls php-pulls closed this in f00bcfb Apr 14, 2020
@kocsismate kocsismate deleted the method-entries-from-stubs3 branch April 14, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nikic