Skip to content

Generate method entries from stubs for a couple of extensions #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Generate method entries from stubs for a couple of extensions #5368

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

There are only 2 notable changes:

  • I'd like to make method visibility modifiers required
  • Made it possible to generate entries for abstract non-public methods (there is one example for it in SPL which used ZEND_RAW_FENTRY)

@kocsismate kocsismate force-pushed the method-entries-from-stubs1 branch from f705e65 to b1eb8b9 Compare April 11, 2020 09:43
@kocsismate kocsismate force-pushed the method-entries-from-stubs1 branch from b1eb8b9 to 7af377f Compare April 11, 2020 09:59
nikic
nikic approved these changes Apr 11, 2020
View reviewed changes
@php-pulls php-pulls closed this in 3fe49d8 Apr 11, 2020
@kocsismate kocsismate deleted the method-entries-from-stubs1 branch April 11, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nikic