Named params implementation

Zend/tests/arg_unpack/non_integer_keys.phpt

@@ -18,4 +18,4 @@ try {
 
 ?>
 --EXPECT--
-Exception: Cannot unpack Traversable with non-integer keys
+Exception: Keys must be of type int|string during argument unpacking

Zend/tests/arg_unpack/string_keys.phpt

@@ -7,11 +7,6 @@ set_error_handler(function($errno, $errstr) {
     var_dump($errstr);
 });
 
-try {
-    var_dump(...[1, 2, "foo" => 3, 4]);
-} catch (Error $ex) {
-    var_dump($ex->getMessage());
-}
 try {
     var_dump(...new ArrayIterator([1, 2, "foo" => 3, 4]));
 } catch (Error $ex) {
@@ -20,5 +15,4 @@ try {
 
 ?>
 --EXPECT--
-string(36) "Cannot unpack array with string keys"
-string(42) "Cannot unpack Traversable with string keys"
+string(68) "Cannot use positional argument after named argument during unpacking"

Zend/tests/assert/expect_015.phpt

@@ -60,6 +60,7 @@ assert(0 && ($a = function &(array &$a, ?X $b = null) use ($c,&$d) : ?X {
             $x = C::${$z . "_1"};
             $x?->y;
             $x?->y();
+            foo(bar: $x);
         }
     }
 }));
@@ -202,6 +203,7 @@ Warning: assert(): assert(0 && ($a = function &(array &$a, ?X $b = null) use($c,
             $x = C::${$z . '_1'};
             $x?->y;
             $x?->y();
+            foo(bar: $x);
         }
 
     }

Zend/tests/bug43343.phpt

@@ -8,4 +8,4 @@ $foo = 'bar';
 var_dump(new namespace::$foo);
 ?>
 --EXPECTF--
-Parse error: syntax error, unexpected token "namespace" in %s on line %d
+Parse error: syntax error, unexpected token "namespace", expecting ":" in %s on line %d

Zend/tests/named_params/__call.phpt

@@ -0,0 +1,37 @@
+--TEST--
+Check that __call() and __callStatic() work with named parameters
+--FILE--
+<?php
+
+class Test {
+    public function __call(string $method, array $args) {
+        $this->{'_'.$method}(...$args);
+    }
+
+    public static function __callStatic(string $method, array $args) {
+        (new static)->{'_'.$method}(...$args);
+    }
+
+    private function _method($a = 'a', $b = 'b') {
+        echo "a: $a, b: $b\n";
+    }
+}
+
+$obj = new class { public function __toString() { return "STR"; } };
+
+$test = new Test;
+$test->method(a: 'A', b: 'B');
+$test->method(b: 'B');
+$test->method(b: $obj);
+Test::method(a: 'A', b: 'B');
+Test::method(b: 'B');
+Test::method(b: $obj);
+
+?>
+--EXPECT--
+a: A, b: B
+a: a, b: B
+a: a, b: STR
+a: A, b: B
+a: a, b: B
+a: a, b: STR

Zend/tests/named_params/__invoke.phpt

@@ -0,0 +1,64 @@
+--TEST--
+Check that __invoke() works with named parameters
+--FILE--
+<?php
+
+class Test {
+    public function __invoke($a = 'a', $b = 'b') {
+        echo "a: $a, b: $b\n";
+    }
+}
+
+class Test2 {
+    public function __invoke($a = 'a', $b = 'b', ...$rest) {
+        echo "a: $a, b: $b\n";
+        var_dump($rest);
+    }
+}
+
+$test = new Test;
+$test(b: 'B', a: 'A');
+$test(b: 'B');
+try {
+    $test(b: 'B', c: 'C');
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+echo "\n";
+
+$test2 = new Test2;
+$test2(b: 'B', a: 'A', c: 'C');
+$test2(b: 'B', c: 'C');
+echo "\n";
+
+$test3 = function($a = 'a', $b = 'b') {
+    echo "a: $a, b: $b\n";
+};
+$test3(b: 'B', a: 'A');
+$test3(b: 'B');
+try {
+    $test3(b: 'B', c: 'C');
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+a: A, b: B
+a: a, b: B
+Unknown named parameter $c
+
+a: A, b: B
+array(1) {
+  ["c"]=>
+  string(1) "C"
+}
+a: a, b: B
+array(1) {
+  ["c"]=>
+  string(1) "C"
+}
+
+a: A, b: B
+a: a, b: B
+Unknown named parameter $c

Zend/tests/named_params/attributes.phpt

@@ -0,0 +1,50 @@
+--TEST--
+Named params in attributes
+--FILE--
+<?php
+
+@@Attribute
+class MyAttribute {
+    public function __construct(
+        public $a = 'a',
+        public $b = 'b',
+        public $c = 'c',
+    ) {}
+}
+
+@@MyAttribute('A', c: 'C')
+class Test1 {}
+
+@@MyAttribute('A', a: 'C')
+class Test2 {}
+
+$attr = (new ReflectionClass(Test1::class))->getAttributes()[0];
+var_dump($attr->getName());
+var_dump($attr->getArguments());
+var_dump($attr->newInstance());
+
+$attr = (new ReflectionClass(Test2::class))->getAttributes()[0];
+try {
+    var_dump($attr->newInstance());
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+string(11) "MyAttribute"
+array(2) {
+  [0]=>
+  string(1) "A"
+  ["c"]=>
+  string(1) "C"
+}
+object(MyAttribute)#1 (3) {
+  ["a"]=>
+  string(1) "A"
+  ["b"]=>
+  string(1) "b"
+  ["c"]=>
+  string(1) "C"
+}
+Named parameter $a overwrites previous argument

Zend/tests/named_params/attributes_duplicate_named_param.phpt

@@ -0,0 +1,11 @@
+--TEST--
+Named params in attributes: Duplicate named parameter error
+--FILE--
+<?php
+
+@@MyAttribute(a: 'A', a: 'A')
+class Test {}
+
+?>
+--EXPECTF--
+Fatal error: Duplicate named parameter $a in %s on line %d

Zend/tests/named_params/attributes_named_flags.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Named flags parameter for Attribute attribute
+--FILE--
+<?php
+
+@@Attribute(flags: Attribute::TARGET_CLASS)
+class MyAttribute {
+}
+
+@@MyAttribute
+function test() {}
+
+(new ReflectionFunction('test'))->getAttributes()[0]->newInstance();
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Attribute "MyAttribute" cannot target function (allowed targets: class) in %s:%d
+Stack trace:
+#0 %s(%d): ReflectionAttribute->newInstance()
+#1 {main}
+  thrown in %s on line %d

Zend/tests/named_params/attributes_named_flags_incorrect.phpt

@@ -0,0 +1,22 @@
+--TEST--
+Named flags parameter for Attribute attribute (incorrect parameter name)
+--FILE--
+<?php
+
+// TODO: This should error at compile-time.
+@@Attribute(not_flags: Attribute::TARGET_CLASS)
+class MyAttribute {
+}
+
+@@MyAttribute
+function test() {}
+
+(new ReflectionFunction('test'))->getAttributes()[0]->newInstance();
+
+?>
+--EXPECTF--
+Fatal error: Uncaught Error: Attribute "MyAttribute" cannot target function (allowed targets: class) in %s:%d
+Stack trace:
+#0 %s(%d): ReflectionAttribute->newInstance()
+#1 {main}
+  thrown in %s on line %d

Zend/tests/named_params/attributes_positional_after_named.phpt

@@ -0,0 +1,14 @@
+--TEST--
+Named params in attributes: Positional after named error
+--FILE--
+<?php
+
+@@Attribute
+class MyAttribute { }
+
+@@MyAttribute(a: 'A', 'B')
+class Test {}
+
+?>
+--EXPECTF--
+Fatal error: Cannot use positional argument after named argument in %s on line %d

Zend/tests/named_params/backtrace.phpt

@@ -0,0 +1,69 @@
+--TEST--
+Extra named params in backtraces
+--FILE--
+<?php
+
+function test($a, ...$rest) {
+    var_dump(debug_backtrace());
+    debug_print_backtrace();
+    throw new Exception("Test");
+}
+
+try {
+    test(1, 2, x: 3, y: 4);
+} catch (Exception $e) {
+    var_dump($e->getTrace());
+    echo $e, "\n";
+}
+
+?>
+--EXPECTF--
+array(1) {
+  [0]=>
+  array(4) {
+    ["file"]=>
+    string(%d) "%s"
+    ["line"]=>
+    int(10)
+    ["function"]=>
+    string(4) "test"
+    ["args"]=>
+    array(4) {
+      [0]=>
+      int(1)
+      [1]=>
+      int(2)
+      ["x"]=>
+      int(3)
+      ["y"]=>
+      int(4)
+    }
+  }
+}
+#0  test(1, 2, x: 3, y: 4) called at [%s:10]
+array(1) {
+  [0]=>
+  array(4) {
+    ["file"]=>
+    string(%d) "%s"
+    ["line"]=>
+    int(10)
+    ["function"]=>
+    string(4) "test"
+    ["args"]=>
+    array(4) {
+      [0]=>
+      int(1)
+      [1]=>
+      int(2)
+      ["x"]=>
+      int(3)
+      ["y"]=>
+      int(4)
+    }
+  }
+}
+Exception: Test in %s:%d
+Stack trace:
+#0 %s(%d): test(1, 2, x: 3, y: 4)
+#1 {main}