Promote some warnings to Errors in Zend basic functions #5325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Mar 29, 2020
| Warning: func_get_arg(): The argument number should be >= 0 in %s on line %d | ||
| bool(false) | ||
| func_get_arg(): Argument #1 ($arg_num) must be greater than or equal to 0 | ||
| func_get_arg(): Argument 0 not passed to function |
There was a problem hiding this comment.
Is this zero-indexing how it seems? 🤔
There was a problem hiding this comment.
Yes, because the argument list starts from 0 for func_get_arg() kinda odd but it's documented.
| @@ -1480,6 +1483,8 @@ ZEND_FUNCTION(restore_exception_handler) | |||
| ZVAL_COPY_VALUE(&EG(user_exception_handler), tmp); | |||
| zend_stack_del_top(&EG(user_exception_handlers)); | |||
| } | |||
|
|
|||
| // TODO Change to void | |||
There was a problem hiding this comment.
@carusogabriel if you are interested :)
There was a problem hiding this comment.
Some of them only work because I removed the false returns by promoting the warnings to error ^^"
There was a problem hiding this comment.
Yeah, I wanted to mention this, too :)
Girgias
force-pushed
the
zend-built-in-function-warning-to-error
branch
2 times, most recently
from
31cee5f to
5919a62
Compare
kocsismate
reviewed
Mar 30, 2020
Girgias
force-pushed
the
zend-built-in-function-warning-to-error
branch
2 times, most recently
from
198323d to
9df93a0
Compare
Girgias
force-pushed
the
zend-built-in-function-warning-to-error
branch
from
9df93a0 to
8531fe8
Compare
nikic
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't know how to handle some of the warnings so I left them be.