Skip to content

Patch add str_starts_with and str_ends_with #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

Patch add str_starts_with and str_ends_with #5300

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ab7b464
Merge pull request #3 from php/master
wkhudgins92 Mar 25, 2020
a709095
Added str_starts_with and str_ends_with
wkhudgins92 Mar 25, 2020
401b5a0
Defined arg info for str_starts_with and str_ends_with
wkhudgins92 Mar 25, 2020
0375e0c
Fixed typo in function name
wkhudgins92 Mar 26, 2020
21810c5
Added tests
wkhudgins92 Mar 26, 2020
85c0572
Modernized the code some as suggested by @guilliamxavier
wkhudgins92 Mar 30, 2020
4e94af7
Fixed typo
wkhudgins92 Mar 30, 2020
7ba82ca
Expanded tests
wkhudgins92 Mar 30, 2020
9dedd4a
Expanded null byte tests for str_starts_with and str_ends_with
wkhudgins92 Mar 31, 2020
321267e
Reworked str_ends_with to use memcmp
wkhudgins92 Mar 31, 2020
31ba825
Fix bug in str_ends_with
wkhudgins92 Mar 31, 2020
30a9eae
fixed trailing spaces
wkhudgins92 Apr 3, 2020
4403607
Modified str_ends_with tests
wkhudgins92 Apr 3, 2020
0ea413f
Removed stray i from vim
wkhudgins92 Apr 3, 2020
8292205
Simplifeid str_starts_with tests
wkhudgins92 Apr 3, 2020
bf63e96
changed spaces to tabs
wkhudgins92 Apr 4, 2020
2509782
Cleaned up str_ends_with tests
wkhudgins92 Apr 4, 2020
075993f
Merge branch 'master' into patch-add-str_starts_with-and-str_ends_with
wkhudgins92 Apr 4, 2020
1b42e9c
Defined str_starts_with and str_ends_with after merge
wkhudgins92 Apr 4, 2020
303b48c
Clean up string tests
wkhudgins92 Apr 9, 2020
52efdbf
Fix str_ends_with test
wkhudgins92 Apr 9, 2020
109afd0
Added one more test to str_starts_with
wkhudgins92 Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ext/standard/tests/strings/str_ends_with.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ var_dump(str_ends_with($testStr, "End"));
var_dump(str_ends_with($testStr, "end"));
var_dump(str_ends_with($testStr, "en"));
var_dump(str_ends_with($testStr, $testStr."a"));
var_dump(str_ends_with("a".$testStr, $testStr));
var_dump(str_ends_with($testStr, ""));
var_dump(str_ends_with("", ""));
var_dump(str_ends_with("", " "));
var_dump(str_ends_with("\x00", ""));
var_dump(str_ends_with("\x00", "\x00"));
var_dump(str_ends_with("a", "\x00"));
var_dump(str_ends_with("a\x00b", "\x00"));
var_dump(str_ends_with("a\x00b", "b"));
var_dump(str_ends_with("a\x00bc", "\x00bc"));
var_dump(str_ends_with("a\x00", "\x00"));
var_dump(str_ends_with("ab\x00c", "b\x00ic"));
var_dump(str_ends_with("a\x00b", "d\x00b"));
var_dump(str_ends_with("a\x00b", "a\x00z"));
var_dump(str_ends_with("a", "\x00a"));
Expand All @@ -31,11 +31,11 @@ bool(false)
bool(false)
bool(true)
bool(true)
bool(true)
bool(false)
bool(true)
bool(true)
bool(false)
bool(false)
bool(true)
bool(true)
bool(false)
Expand Down