Skip to content

Improve error messages of ext/hash #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Improve error messages of ext/hash #5275

wants to merge 3 commits into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Mar 18, 2020 •
edited
Loading

  • A number of error messages were revamped
  • 3 warnings were promoted to an exception (in a separate commit)

kocsismate
kocsismate commented Mar 18, 2020
View reviewed changes
nikic
nikic reviewed Mar 23, 2020
View reviewed changes
@kocsismate kocsismate force-pushed the consistent-error-messages3-hash branch from 1ddd102 to d524964 Compare March 23, 2020 16:37
@nikic
Copy link
Member

nikic commented Mar 23, 2020

Test failure looks legit.

@kocsismate kocsismate force-pushed the consistent-error-messages3-hash branch from d524964 to 8eefdc9 Compare March 23, 2020 17:56
@php-pulls php-pulls closed this in c5fe1a1 Mar 24, 2020
@kocsismate kocsismate deleted the consistent-error-messages3-hash branch March 24, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nikic