Remove depreacted curly brace offset syntax #5221
Conversation
|
I'm afraid this requires discussion on internals@, since the respective RFC was not about the removal. |
Isn't the usual process to remove everything deprecated in the previous release cycle? |
Most RFCs dealing with deprecations also set a timeline for the removal. This RFC, however, put the removal in the "future scope" section, and did not specify the version ("in PHP 8 or another future release"). So I think the intent to remove the feature should be at least announced on internals@. |
Girgias
force-pushed
the
remove-deprecated-alternative-syntax
branch
from
4ab82a8 to
8f5ecf6
Compare
Girgias
force-pushed
the
remove-deprecated-alternative-syntax
branch
from
8f5ecf6 to
b0327b9
Compare
| if (ast->attr & ZEND_DIM_ALTERNATIVE_SYNTAX) { | ||
| ast->attr &= ~ZEND_DIM_ALTERNATIVE_SYNTAX; /* remove flag to avoid duplicate warning */ | ||
| zend_error(E_DEPRECATED, "Array and string offset access syntax with curly braces is deprecated"); | ||
| } |
There was a problem hiding this comment.
I'd prefer to retain this code and generate an E_COMPILE_ERROR here, so we can provide a better error message. We can drop the actual grammar if/when we run into conflicts.
There was a problem hiding this comment.
Can you please add tests for the two errors (one in constexpr context, one outside)?
Girgias
force-pushed
the
remove-deprecated-alternative-syntax
branch
4 times, most recently
from
7ad85b2 to
37a5ca6
Compare
Girgias
force-pushed
the
remove-deprecated-alternative-syntax
branch
from
37a5ca6 to
fe76690
Compare
|
If there are no objections I'll merge this in a week |
Zend/zend_compile.c
Outdated
| @@ -2614,9 +2614,8 @@ static inline void zend_emit_assign_znode(zend_ast *var_ast, znode *value_node) | |||
| static zend_op *zend_delayed_compile_dim(znode *result, zend_ast *ast, uint32_t type) /* {{{ */ | |||
| { | |||
| if (ast->attr == ZEND_DIM_ALTERNATIVE_SYNTAX) { | |||
| zend_error(E_DEPRECATED, "Array and string offset access syntax with curly braces is deprecated"); | |||
| zend_error(E_COMPILE_ERROR, "Array and string offset access syntax with curly braces is not supported"); | |||
There was a problem hiding this comment.
| zend_error(E_COMPILE_ERROR, "Array and string offset access syntax with curly braces is not supported"); | |
| zend_error(E_COMPILE_ERROR, "Array and string offset access syntax with curly braces is no longer supported"); |
Maybe?
There was a problem hiding this comment.
Made the change just checking via CI I didn't forget any other place before merging
Girgias
force-pushed
the
remove-deprecated-alternative-syntax
branch
from
fe76690 to
53af2b8
Compare
Girgias
force-pushed
the
remove-deprecated-alternative-syntax
branch
from
53af2b8 to
23302c0
Compare
No description provided.