Skip to content

Deprecate old ReflectionParameter type declaration APIs #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Deprecate old ReflectionParameter type declaration APIs #5209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Zend/tests/bug69802_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ $f = (new ReflectionFunction('iterator_to_array'))->getClosure();
$r = new ReflectionMethod($f, '__invoke');
var_dump($r->getParameters()[0]->getClass());
?>
--EXPECT--
--EXPECTF--
Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
object(ReflectionClass)#4 (1) {
["name"]=>
string(11) "Traversable"
Expand Down
7 changes: 6 additions & 1 deletion Zend/tests/type_declarations/callable_002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ $rc = new ReflectionFunction($closure);
var_dump($rc->getParameters()[0]->isCallable());

?>
--EXPECT--
--EXPECTF--
Deprecated: Function ReflectionParameter::isCallable() is deprecated in %s on line %d
bool(true)

Deprecated: Function ReflectionParameter::isCallable() is deprecated in %s on line %d
bool(true)

Deprecated: Function ReflectionParameter::isCallable() is deprecated in %s on line %d
bool(true)
15 changes: 0 additions & 15 deletions ext/intl/tests/bug66921.phpt
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions ext/reflection/php_reflection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6396,11 +6396,11 @@ static const zend_function_entry reflection_parameter_functions[] = {
ZEND_ME(reflection_parameter, canBePassedByValue, arginfo_class_ReflectionParameter_canBePassedByValue, 0)
ZEND_ME(reflection_parameter, getDeclaringFunction, arginfo_class_ReflectionParameter_getDeclaringFunction, 0)
ZEND_ME(reflection_parameter, getDeclaringClass, arginfo_class_ReflectionParameter_getDeclaringClass, 0)
ZEND_ME(reflection_parameter, getClass, arginfo_class_ReflectionParameter_getClass, 0)
ZEND_DEP_ME(reflection_parameter, getClass, arginfo_class_ReflectionParameter_getClass, 0)
ZEND_ME(reflection_parameter, hasType, arginfo_class_ReflectionParameter_hasType, 0)
ZEND_ME(reflection_parameter, getType, arginfo_class_ReflectionParameter_getType, 0)
ZEND_ME(reflection_parameter, isArray, arginfo_class_ReflectionParameter_isArray, 0)
ZEND_ME(reflection_parameter, isCallable, arginfo_class_ReflectionParameter_isCallable, 0)
ZEND_DEP_ME(reflection_parameter, isArray, arginfo_class_ReflectionParameter_isArray, 0)
ZEND_DEP_ME(reflection_parameter, isCallable, arginfo_class_ReflectionParameter_isCallable, 0)
ZEND_ME(reflection_parameter, allowsNull, arginfo_class_ReflectionParameter_allowsNull, 0)
ZEND_ME(reflection_parameter, getPosition, arginfo_class_ReflectionParameter_getPosition, 0)
ZEND_ME(reflection_parameter, isOptional, arginfo_class_ReflectionParameter_isOptional, 0)
Expand Down
9 changes: 8 additions & 1 deletion ext/reflection/tests/ReflectionClass_isArray.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,15 @@ foreach ($reflection->getParameters() as $parameter) {
var_dump($parameter->isArray());
}
?>
--EXPECT--
--EXPECTF--
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(true)

Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(true)

Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)

Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
3 changes: 2 additions & 1 deletion ext/reflection/tests/bug26695.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@ $class = $params[0]->getClass();

var_dump($class->getName());
?>
--EXPECT--
--EXPECTF--
Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
string(3) "Foo"
3 changes: 2 additions & 1 deletion ext/reflection/tests/bug29268.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ foreach($parameters as $parameter)
}
echo "ok\n";
?>
--EXPECT--
--EXPECTF--
Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
__autoload(A)
A
ok
3 changes: 2 additions & 1 deletion ext/reflection/tests/bug39884.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ $test1->paramTest($test2);
$refParam = new ReflectionParameter(array('stubParamTest', 'paramTest'), 'param');
var_dump($refParam->getClass());
?>
--EXPECT--
--EXPECTF--
Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
object(ReflectionClass)#4 (1) {
["name"]=>
string(13) "stubParamTest"
Expand Down
4 changes: 3 additions & 1 deletion ext/reflection/tests/bug69802.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@ echo $r->getParameters()[0], "\n";
echo $r->getReturnType()->getName(), "\n";
echo $r,"\n";
?>
--EXPECT--
--EXPECTF--
string(1) "x"

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
object(ReflectionClass)#4 (1) {
["name"]=>
string(8) "stdClass"
Expand Down
86 changes: 71 additions & 15 deletions ext/reflection/tests/parameters_002.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,69 +72,97 @@ check_params(new ReflectionFunction('test'));
check_params(new ReflectionMethod('test::method'));

?>
--EXPECT--
--EXPECTF--
#####test()#####
===0===
getName: string(3) "nix"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: NULL
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===1===
getName: string(2) "ar"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: NULL
isArray: bool(true)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(true)
allowsNull: bool(false)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===2===
getName: string(3) "ref"
isPassedByReference: bool(true)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: NULL
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===3===
getName: string(3) "std"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: stdClass
getDeclaringClass: NULL
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(false)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===4===
getName: string(2) "na"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
Class NonExistingClass does not exist
getDeclaringClass: NULL
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(false)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===5===
getName: string(3) "opt"
isPassedByReference: bool(true)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: stdClass
getDeclaringClass: NULL
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(true)
isDefaultValueAvailable: bool(true)
getDefaultValue: NULL
===6===
getName: string(3) "def"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: NULL
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(true)
isDefaultValueAvailable: bool(true)
Expand All @@ -143,64 +171,92 @@ getDefaultValue: string(6) "FooBar"
===0===
getName: string(3) "nix"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: test
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===1===
getName: string(2) "ar"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: test
isArray: bool(true)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(true)
allowsNull: bool(false)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===2===
getName: string(3) "ref"
isPassedByReference: bool(true)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: test
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===3===
getName: string(3) "std"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: stdClass
getDeclaringClass: test
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(false)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===4===
getName: string(2) "na"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
Class NonExistingClass does not exist
getDeclaringClass: test
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(false)
isOptional: bool(false)
isDefaultValueAvailable: bool(false)
===5===
getName: string(3) "opt"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: stdClass
getDeclaringClass: test
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(true)
isDefaultValueAvailable: bool(true)
getDefaultValue: NULL
===6===
getName: string(3) "def"
isPassedByReference: bool(false)

Deprecated: Function ReflectionParameter::getClass() is deprecated in %s on line %d
getClass: NULL
getDeclaringClass: test
isArray: bool(false)
isArray:
Deprecated: Function ReflectionParameter::isArray() is deprecated in %s on line %d
bool(false)
allowsNull: bool(true)
isOptional: bool(true)
isDefaultValueAvailable: bool(true)
Expand Down