Add stubs for Intl BreakIterator #5207
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
intl-breakiterator-stubs
branch
2 times, most recently
from
f2021f4 to
b8ce117
Compare
nikic
reviewed
Feb 25, 2020
First check for IS_INDIRECT and de-indirect it directly there. Handle the error cases later.
kocsismate
force-pushed
the
intl-breakiterator-stubs
branch
from
b8ce117 to
d9081e7
Compare
|
I fixed the issue with |
|
I am not sure how one of your commits ended up being in the changeset... Or maybe mirroring stopped working between GitHub and PHP's Git server? 🤔 |
|
@kocsismate Yes, GitHub was down when I pushed that commit, so it didn't sync. |
nikic
approved these changes
Feb 25, 2020
kocsismate
force-pushed
the
intl-breakiterator-stubs
branch
from
d9081e7 to
4b41bfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.