Disallow passing array as number to NumberFormatter::format()

[cmb69]

Array to number conversion makes no sense here, and is likely to hide
a programming error. Therefore we disallow passing an array in the
first place.

---

This is a follow-up to #5141 (comment). Given PR #5092 is work in progress, I've not spend much time on constructing a good error message.

[Girgias]

Wouldn't it maybe be better to say that the value must be a scalar? Slight glimpse at the source code but non-stringable object should probably also throw.

(and small drive-by but the invalid format should also throw a ValueError but that should probably be done while converting most of them from the extension)

[nikic]

Eh, maybe accept int|float directly? We only have that in fast zpp right now though.

[Girgias]

Eh, maybe accept int|float directly? We only have that in fast zpp right now though.

I'm imagining some people might use strings directly but that does seem like a more reasonable choice indeed.

[nikic]

@Girgias That's fine as long as they use weak types. For strict types a string should of course throw.

[Girgias]

@Girgias That's fine as long as they use weak types. For strict types a string should of course throw.

Indeed, makes sense :)

[cmb69]

Eh, maybe accept int|float directly?

Yes, makes perfect sense.

[nikic]

LG. As this is the only use of n in (normal) zpp right now, I'd suggest adding an explicit test for the case where it throws.

[cmb69]

Thanks! I've re-added the adapted bug48227.phpt, and applied as 6ee6097.