Remove value from comment in php.ini files #5164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather rephrase this by saying that the default is 128MB. |
|
Other configuration options does not have simillar comment, see for example Lines 832 to 834 in 2ff7994 I am against any value there as for example in our Ansible playbook we generate final php.ini from template and any comment about "default value" is misleading as noone knows, if this is a default from PHP directly, from deploy, or if this was modified by an user when the user was changing this value. |
nikic
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove value from comment in php.ini files, otherwise when the actual value is changed, the comment may be unclear.