Fix #78666 mysqli_options generates Warning on var_dump() #5121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
mysqli-var-dump
branch
from
471c0e8 to
39884bb
Compare
|
Bug fixes should target the lowest supported version, currently 7.3. |
nikic
reviewed
Jan 27, 2020
nikic
reviewed
Jan 27, 2020
|
I'd say this is okay for 7.4 ( |
kocsismate
force-pushed
the
mysqli-var-dump
branch
4 times, most recently
from
26b889c to
1bc86de
Compare
kocsismate
commented
Jan 28, 2020
nikic
reviewed
Jan 28, 2020
nikic
reviewed
Jan 28, 2020
kocsismate
force-pushed
the
mysqli-var-dump
branch
2 times, most recently
from
3bb6b03 to
0d250c8
Compare
kocsismate
force-pushed
the
mysqli-var-dump
branch
from
0d250c8 to
0ef6b2b
Compare
nikic
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #5058
If changing the signature of mysqli functions is too late for PHP 7.4, I can switch the base branch to master.
There is one test that fails (bug54221.phpt), but I can't find out exactly why...