Always delete tempfile created by ftruncate test. #5043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ftruncate() test will fill up the disk when the disk has less than 2GB of space left, on some systems. I think it expands the file to less than 2GB, then returns an error code, and the file remains at the larger size. Because the disk is full, the `--CLEAN--` script can't be saved to `ftruncate_bug76422.clean.php` to be executed, and the cleanup can't be run. Subsequent tests also fail to run.
nikic
approved these changes
Dec 30, 2019
TysonAndre
added a commit
to TysonAndre/php-src
that referenced
this pull request
Mar 21, 2020
Followup to php#5043 In the middle of running this test with TESTS=-j9, run-tests.php stopped the test suite because the partition started with 3.5GB of free disk space and new test files couldn't be created. Reclaiming the disk space of that file also took a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ftruncate() test will fill up the disk when the disk has less than
2GB of space left, on some systems.
I think it expands the file to less than 2GB, then returns an error code,
and the file remains at the larger size.
Because the disk is full, the
--CLEAN--script can't be saved toftruncate_bug76422.clean.phpto be executed, and the cleanup can't be run.Subsequent tests also fail to run.
https://www.php.net/manual/en/function.disk-free-space.php is also worth considering for the --SKIP-- section, but lower priority than reclaiming the space if needed.