Fix F1 type information in OPCache #5025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Dec 19, 2019
kocsismate
commented
Dec 19, 2019
nikic
approved these changes
Dec 20, 2019
|
FYI we should also be able to remove many FN() entries that have matching stubs. |
|
Thanks for the review! I'll wait for the CI to finish, squash, and then apply it to master.
Cool! I though that they are also needed. I'll have another shot at them then. |
kocsismate
added a commit
to kocsismate/php-src
that referenced
this pull request
Dec 20, 2019
kocsismate
added a commit
to kocsismate/php-src
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the
F1type information according to the available stubs (+ sometimes double checked the implementation).FNlooked good.Additionally, I fixed some issues + adjusted formatting of the stubs.