Add stubs for standard library - final round #5017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Dec 16, 2019
kocsismate
force-pushed
the
standard-various5
branch
from
958cdd0 to
9907946
Compare
nikic
reviewed
Dec 19, 2019
nikic
reviewed
Dec 19, 2019
nikic
reviewed
Dec 19, 2019
nikic
reviewed
Dec 19, 2019
|
Fixup'd the issues :) Thanks for the suggestions! |
nikic
approved these changes
Dec 20, 2019
| * @param array|string $param2 | ||
| * @param mixed $value | ||
| */ | ||
| function stream_context_set_option($context, $param2, string $option_name = UNKNOWN, $value = UNKNWOWN): bool {} |
There was a problem hiding this comment.
Suggested change
| function stream_context_set_option($context, $param2, string $option_name = UNKNOWN, $value = UNKNWOWN): bool {} | |
| function stream_context_set_option($context, $param2, string $option_name = UNKNOWN, $value = UNKNOWN): bool {} |
There was a problem hiding this comment.
Oh, my bad.. I'll fix it now.
kocsismate
force-pushed
the
standard-various5
branch
from
8c4ebfc to
f28f016
Compare
kocsismate
added a commit
to kocsismate/php-src
that referenced
this pull request
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, all the functions in the standard library will have a stub. 🎉