Adding ability to create a DateTime or DateTimeImmutable from an inst… #5016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Dec 16, 2019
|
+1 on these methods. Ideally we'd have just added these instead of createFromMutable+createFromImmutable. |
derickr
reviewed
Dec 16, 2019
|
@mikeSimonson |
nikic
reviewed
Dec 16, 2019
mikeSimonson
force-pushed
the
datetime-create-from-interface
branch
from
fbcad83 to
fea4392
Compare
mikeSimonson
force-pushed
the
datetime-create-from-interface
branch
from
fea4392 to
2bbf3d4
Compare
|
As far as I can tell this PR is ready tested and respect the CS ? |
nikic
approved these changes
Dec 30, 2019
derickr
approved these changes
Jan 3, 2020
| int(1) | ||
| ["timezone"]=> | ||
| string(6) "+01:00" | ||
| } |
There was a problem hiding this comment.
Nit: please make sure the last line also has a new line at the end (but not an extra empty line)
| int(1) | ||
| ["timezone"]=> | ||
| string(6) "+01:00" | ||
| } |
There was a problem hiding this comment.
Nit: please make sure the last line also has a new line at the end (but not an extra empty line)
|
It seems to me that this PR obsoletes PR #3394. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ance of the interface