Change some warnings to ValueErrors in MBString extension #4971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Dec 6, 2019
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
from
d865892 to
80f9e8e
Compare
|
Dropped the ones which are being dealt by #4977 and added some other conversions in a follow up commit. |
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
from
0039293 to
5e7aa47
Compare
|
Kinda WIP until I figure out why the negative offset in normal mode are not returning the correct error code in the
|
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
from
5e7aa47 to
31e9a35
Compare
|
It's maybe better that I do the mbfilter changes in an other PR, as currently there are already 3 cases which are "nicer" and don't need to call |
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
from
31e9a35 to
793f9b2
Compare
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
2 times, most recently
from
a9571fc to
70d6716
Compare
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
2 times, most recently
from
8c9f773 to
3d06d83
Compare
Girgias
force-pushed
the
mbstring-warnings-to-errors
branch
from
3d06d83 to
2c51bef
Compare
|
Surpassed by a bunch of other stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deleted one test file whose test are covered by loads of other ones.