Skip to content

Add more CONFLICTS tags #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add more CONFLICTS tags #4908

wants to merge 1 commit into from

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Nov 13, 2019

No description provided.

cmb69
cmb69 approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch. Thanks!

It seems to me that these tests are at least partially testing ZPP, and as such could be simplified or even removed. This PR looks like a sensible improvement on its own though.

@php-pulls php-pulls closed this in 92fd965 Nov 13, 2019
@villfa villfa deleted the conflicts-obscure_filename branch November 13, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Category: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@villfa @cmb69 @carusogabriel