Skip to content

Fix conflicts in windows ACL tests #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix conflicts in windows ACL tests #4898

wants to merge 1 commit into from

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Nov 9, 2019

No description provided.

@cmb69
Copy link
Member

cmb69 commented Nov 9, 2019

Ah, great! Have you've been able to reproduce https://bugs.php.net/78551, and would this patch fix it?

@villfa
Copy link
Contributor Author

villfa commented Nov 9, 2019

I was not able to reproduce it neither, so I can't guarantee it will definitely fix it.

cmb69
cmb69 approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In any way, this would be an improvement, so I think this should go into 7.4+, and if these tests won't fail any longer (bug44859_4.phpt fails occasionally on AppVeyor), we can still backport.

@php-pulls php-pulls closed this in ce41795 Nov 9, 2019
@villfa villfa deleted the conflicts-win-acl branch November 9, 2019 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@villfa @cmb69