Fix php8 compile error using zend_parse_parameters_throw() #4896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug introduced in 4008704 The trailing comma is followed by `)` when the varargs list is empty in the macro, which is a syntax error in C This fixes compilation of code such as the following PHP_FUNCTION(get_metadata) { if (zend_parse_parameters_throw(ZEND_NUM_ARGS(), "") == FAILURE) { return; }
|
Are you on Windows? |
nikic
approved these changes
Nov 8, 2019
|
No, I'm not. I'm using gcc 5.4.0 on linux mint |
|
Thank, good catch. See also https://docs.microsoft.com/en-us/cpp/preprocessor/variadic-macros?view=vs-2019#remarks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in 4008704
The trailing comma is followed by
)when the varargs listis empty in the macro, which is a syntax error in C
This fixes compilation of code such as the following