Skip to content

Add another round of stubs for various functions in the standard library #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Nov 1, 2019

This PR add stubs for quite some functions in the standard lib.

The work is dependent on #4879 - the signature of some functions depend on whether warnings can be promoted to exceptions or not.

@nikic
Copy link
Member

nikic commented Nov 6, 2019

@kocsismate You may want to request a php.net git account at https://www.php.net/git-php.php, so you can commit future changes yourself.

Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the sleep/register_tick_function changes separately from the stub additions.

@kocsismate
Copy link
Member Author

Yes, that's what I planned. I'll do it tonight.

@kocsismate
Copy link
Member Author

Closing via 662afc8, afe4a87, and ab6b412

@kocsismate kocsismate closed this Nov 7, 2019
@kocsismate kocsismate deleted the standard-various2 branch November 7, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants