Skip to content

Test #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Test #4759

wants to merge 3 commits into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Sep 30, 2019

#4746 with gcovr from pip. Creating a separate PR so this doesn't get force pushed again...

@nikic
Copy link
Member Author

nikic commented Sep 30, 2019

First attempt failed because the binary isn't found ... trying again with sudo -H, hopefully that will install it globally.

@gerardroche
Copy link
Contributor

I've added the gcovr pip install, which installs 4.1, to https://github.com/php/php-src/pull/4746/files. I've also broken the job out into a specific coverage job (I've temporarily commented out most of the other jobs until it's working properly).

@nikic
Copy link
Member Author

nikic commented Sep 30, 2019

Looks like it worked: https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=2971&view=codecoverage-tab

@krakjoe
Copy link
Member

krakjoe commented Sep 30, 2019

We are basically pipeline gods right now ... great stuff ...

@nikic nikic closed this Sep 30, 2019
gerardroche added a commit to gerardroche/php-src that referenced this pull request Oct 1, 2019
* Add an Azure Publish Code Coverage Results task
* Add `make gcovr-html` to generate a gcovr test coverage report in HTML
* Add `make gcovr-xml` to generate a gcovr test coverage report in XML
* Remove `test` target dependency from `make lcov-html`; Run the two targets together instead: `make test lcov-html`.

Re: php#4739 (comment)

See: https://externals.io/message/107113,
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops,
and php#4759.
gerardroche added a commit to gerardroche/php-src that referenced this pull request Oct 1, 2019
* Add an Azure Publish Code Coverage Results task
* Add `make gcovr-html` to generate a gcovr test coverage report in HTML
* Add `make gcovr-xml` to generate a gcovr test coverage report in XML
* Remove `test` target dependency from `make lcov-html`; Run the two targets together instead: `make test lcov-html`.

Re: php#4739 (comment)

See: https://externals.io/message/107113,
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops,
and php#4759.
gerardroche added a commit to gerardroche/php-src that referenced this pull request Oct 1, 2019
* Add an Azure Publish Code Coverage Results task
* Add `make gcovr-html` to generate a gcovr test coverage report in HTML
* Add `make gcovr-xml` to generate a gcovr test coverage report in XML
* Remove `test` target dependency from `make lcov-html`; Run the two targets together instead: `make test lcov-html`.

Re: php#4739 (comment)

See: https://externals.io/message/107113,
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops,
and php#4759.
nikic pushed a commit to gerardroche/php-src that referenced this pull request Oct 11, 2019
* Add an Azure Publish Code Coverage Results task
* Add `make gcovr-html` to generate a gcovr test coverage report in HTML
* Add `make gcovr-xml` to generate a gcovr test coverage report in XML
* Remove `test` target dependency from `make lcov-html`; Run the two targets together instead: `make test lcov-html`.

Re: php#4739 (comment)

See: https://externals.io/message/107113,
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops,
and php#4759.
php-pulls pushed a commit that referenced this pull request Oct 11, 2019
* Add an Azure Publish Code Coverage Results task
* Add `make gcovr-html` to generate a gcovr test coverage report in HTML
* Add `make gcovr-xml` to generate a gcovr test coverage report in XML
* Remove `test` target dependency from `make lcov-html`;
  Run the two targets together instead: `make test lcov-html`.

Re: #4739 (comment)

See: https://externals.io/message/107113,
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/test/publish-code-coverage-results?view=azure-devops,
and #4759.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants