Fix auto_detect_line_endings type #4700
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this bugfix could break some setups, I think there should be an accompanying bug report to which we can refer in the changelog. |
|
@cmb69 Good idea. |
|
Thanks! Applied as fdcca93. |
|
@cmb69 wouldn't this be an ABI break for 7.2? |
|
Oh, indeed! So revert and merge into master only? |
|
@cmb69 7.4+ should be fine tbh, its just a normal bug fix, rather we fix it for 7.4 than waiting another year |
|
Leaving the type as zend_long and using OnUpdateBool should work fine for 7.2. (It may not write a proper boolean depending on endianness, but that doesn't matter so long as the value is non-zero.) |
php-pulls
pushed a commit
that referenced
this pull request
Sep 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
auto_detect_line_endingstoonwithini_setdoesn't enable it, because the value's parsed as a long.