Skip to content

Promote warnings to errors in array_merge(_recursive)() and array_replace() #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Promote warnings to errors in array_merge(_recursive)() and array_replace() #4586

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 21, 2019

Split from #4566

Grouping these together as they use the same internal handler.

SjonHortensius
SjonHortensius approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@SjonHortensius SjonHortensius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did notice the case change in the error-message but I agree it is better

@krakjoe
Copy link
Member

krakjoe commented Aug 29, 2019

Merged as 20edea5

@krakjoe krakjoe closed this Aug 29, 2019
@Girgias Girgias deleted the replace-array-warnings2errors branch August 29, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SjonHortensius SjonHortensius SjonHortensius approved these changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Girgias @krakjoe @SjonHortensius @kocsismate