Promote warnings to errors in array_push() #4585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SjonHortensius
approved these changes
Aug 21, 2019
nikic
reviewed
Aug 26, 2019
| @@ -3168,8 +3168,8 @@ PHP_FUNCTION(array_push) | |||
|
|
|||
| if (zend_hash_next_index_insert(Z_ARRVAL_P(stack), &new_var) == NULL) { | |||
| Z_TRY_DELREF(new_var); | |||
| php_error_docref(NULL, E_WARNING, "Cannot add element to the array as the next element is already occupied"); | |||
| RETURN_FALSE; | |||
| zend_throw_error(NULL, "Cannot add element to the array as the next element is already occupied"); | |||
There was a problem hiding this comment.
So, this is actually a pretty generic warning, in particular also used by $foo[] = $x, see
Line 1971 in 0038db2
$foo[] = $x and array_push($foo, $x).
Girgias
force-pushed
the
push-array-warnings2error
branch
from
59b3ab9 to
8f780ab
Compare
|
Appveyor failure seems unrelated. |
theodorejb
reviewed
Aug 27, 2019
Girgias
force-pushed
the
push-array-warnings2error
branch
from
2a753b9 to
7680d5b
Compare
|
This probably needs to wait the result of the Reclassifying Engine Warnings RFC. |
|
That RFC has been accepted (this issue should trigger an |
nikic
approved these changes
Sep 29, 2019
|
Merged as 1ca4ab0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4566