Promote warnings to errors in array_count_values() #4580
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SjonHortensius
approved these changes
Aug 21, 2019
|
Not sure this change is appropriate: Note that this warning is really just a warning, not a proper error condition. The function is still going to count other values, and skip over those with unsupported types. The same is not possible if an exception is thrown. |
|
I agree, this might not be as straight-forward as it seems. The warning+result allows users to choose between failing and continuing. I only use codebases that convert all warnings to exceptions anyway but this change removes the option that other might choose (using the result even though a warning occured as illustrated by the testcase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4566