Skip to content

Promote warnings to errors in array_rand() #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Promote warnings to errors in array_rand() #4579

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 20, 2019

Split from #4566

@nikic
Copy link
Member

nikic commented Aug 26, 2019

As the array function stubs are now merged, please also update

php-src/ext/standard/basic_functions.stub.php

Line 248 in d5f42d6

/** @return int|string|array|null */
when merging this.

@Girgias
Copy link
Member Author

Girgias commented Aug 26, 2019

Merged in as c1c8538

@Girgias Girgias closed this Aug 26, 2019
@Girgias Girgias deleted the rand-array-warning2error branch August 26, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

@SjonHortensius SjonHortensius SjonHortensius approved these changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Girgias @nikic @SjonHortensius @kocsismate