Skip to content

Promote warnings to errors in array_multisort() #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Promote warnings to errors in array_multisort() #4575

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 20, 2019

Split from #4566

nikic
nikic approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also change the RETURN_FALSE in MULTISORT_ABORT to just return, to clarify that a false return value is not possible.

@Girgias
Copy link
Member Author

Girgias commented Aug 21, 2019

Commited as eaf66df

@Girgias Girgias closed this Aug 21, 2019
@Girgias Girgias deleted the multisort-warning2error branch August 21, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Warning promotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Girgias @nikic @kocsismate