Convert remaining array function arginfo to PHP stubs #4543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 15, 2019
nikic
reviewed
Aug 16, 2019
nikic
reviewed
Aug 20, 2019
theodorejb
force-pushed
the
array_function_stubs
branch
from
e9c8aad to
cc1873a
Compare
nikic
reviewed
Aug 26, 2019
|
Merged as d5f42d6 with the above tweak. Thanks! |
|
Followup in 0038db2 to fix the duplicate warning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates
gen_stub.phpto supportZEND_SEND_PREFER_REFarguments, and check that only the last parameter is variadic.