main/php_ini.c: remove dead code

[glensc]

main/php_ini.c:492 always initializes php_ini_search_path being empty:

php_ini_search_path[0] = 0;

That change was introduced in acb1e07 by @dstogov

[glensc]

NOTE: this patch was originally created from php-7.4.0beta2 tag, but as the bug is old as 5.2.0, should be merged to all active branches.

@dstogov @petk @derickr can you merge this for 7.4 and below? :)

[petk]

cc @nikic I believe is the right ping here for the review. :) Merging dead code to PHP 7.4 is from my point of view still ok. Less diffs between 7.4 and 8.0 is very smart if we can do that.

[nikic]

It might make more sense to factor out this repetitive code-pattern into a function (append_ini_path or something).

[glensc]

@nikic exactly my idea. have some static method inside that same source file to avoid the repeative code.

[glensc]

ideally, I'd move those large platform-specific #ifdef blocks inside method also as separate static functions, then the main function is easier to follow.

[glensc]

... added something

[glensc]

I think the size parameter should be min(size, MAXPATHLEN), not to overflow phprc_path.

[glensc]

@nikic fix this or leave as is?

[nikic]

Appveyor:

main\php_ini.c(419): warning C4101: 'reg_location': unreferenced local variable
main\php_ini.c(524): error C2065: 'reg_location': undeclared identifier
main\php_ini.c(524): warning C4047: '=': 'int' differs in levels of indirection from 'char *'
main\php_ini.c(525): error C2065: 'reg_location': undeclared identifier
main\php_ini.c(525): warning C4047: '!=': 'int' differs in levels of indirection from 'void *'
main\php_ini.c(526): error C2065: 'reg_location': undeclared identifier
main\php_ini.c(526): warning C4047: 'function': 'char *' differs in levels of indirection from 'int'
main\php_ini.c(526): warning C4024: 'append_ini_path': different types for formal and actual parameter 3
main\php_ini.c(527): error C2065: 'reg_location': undeclared identifier
main\php_ini.c(527): warning C4022: '_efree': pointer mismatch for actual parameter 1
php_scandir.c

[glensc]

moved too much, fixed 62b362e

[glensc]

do you want me to rebase this to lowest branch? or maintainers can handle that? and in that case, what is that branch?

[nikic]

You are returning a reference to stack memory here. The pointer will be invalidated when the function returns.

[glensc]

suggestions? always strdup value, return NULL if no value? playing with is_allocated variable seems overkill, as this code path is invoked only on init (not request init)?

[cmb69]

One option would be to not return anything from get_env_location, but to pass the buffer into the function.

[ramsey]

What's the status of this RFC? Is it still relevant? Should it target PHP-8.0?

[glensc]

Only 3 years, 4 months to merge! thanks :)