Skip to content

Convert gettext functions arginfo to php stubs #4506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Convert gettext functions arginfo to php stubs #4506

wants to merge 1 commit into from

Conversation

duncan3dc
Copy link
Member

No description provided.

nikic
nikic reviewed Aug 10, 2019
View reviewed changes
@duncan3dc duncan3dc force-pushed the convert-gettext-arginfo branch from 4d7b14c to 9294b54 Compare August 10, 2019 15:54
nikic
nikic approved these changes Aug 10, 2019
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side-note, maybe we should convert those length checks to throw an exception in PHP 8, and avoid some of these unnecessary false return values...

@php-pulls php-pulls closed this in f9980e6 Aug 10, 2019
@duncan3dc duncan3dc deleted the convert-gettext-arginfo branch August 10, 2019 16:22
@cmb69 cmb69 added Stubs and removed Feature labels Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@duncan3dc @nikic @cmb69 @carusogabriel