-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Bump PHP API numbers and versions #4468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
During the pre-release phase API version numbers are not bumped. There will be a bump somewhere close to the PHP 7.4 release, when we are sure that no more API changes are necessary. |
Thanks for the explanation @nikic. cc @EricSten-MSFT see above explanation ☝️ ... I think extensions should be able to be built using the current API version... |
Just fyi, I recommend doing API checks in code based on |
@nikic FYI, |
@EricSten-MSFT |
@Majkl578 That's nice, but still can't be used in an |
I think I haven't been clear enough here: Extensions can not and should not support anything but the latest pre-release version. There is no need to distinguish between alpha 1 and beta 1, because beta 1 is the only thing that needs to be supported (for the cases where it makes a difference). API changes in pre-release versions happen very often and are not subject to fine-grained tracking, on the assumption that it makes little sense for extensions to support all random snapshots of master -- ultimately they just need to support the GA release. The internal API and ABI become mostly stable at beta 1 (which is now), though there may still be changes if they turn out to be necessary. API and ABI are fully frozen prior to GA and are assigned final numbers that will remain unchanged for the whole minor version from that point on. I hope that makes some sense. We could of course change our procedure and for example start assigning new API/ABI numbers for each alpha/beta release to allow extensions so that extensions can be compatible with each pre-release. I'm not sure I see what the value in doing that would be though. |
Well, if I understood this correctly technically, we should bump these numbers, yes for each milestone i.e. the tag. Otherwise, PHP extensions should according to this now take into consideration only states of PHP between versions of PHP 7.3.x and PHP 7.4.0. From PHP extensions point of view there is no difference between the alpha, beta or final GA release then. So a simple ditch of alpha versions is a precondition here for fixing the extensions code out there. Users won't be having alpha somewhere and beta release somewhere else. Yes, there are hosting services that provide RC releases already but I think GA should be the final target for all then. |
@nikic Ah, okay, so, you're saying that I don't have to worry about compiling for alpha1, now that beta1 is out. Got it. Thx! |
Yeah, that's right! |
API was changed since the last bump 8ec0cf8