Skip to content

Bump PHP_JSON_VERSION #4459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump PHP_JSON_VERSION #4459

wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Jul 22, 2019

Json extension version should be bumped?

PHP json 1.7.0 from PHP 7.3 !== 1.7.0 from PHP 7.4

PHP_VERSION? 1.8.0? 1.7.1?

Thanks.

@petk petk added the Quickfix label Jul 22, 2019
@nikic
Copy link
Member

nikic commented Jul 24, 2019

cc @bukka

I think setting this to PHP_VERSION is the right thing, but iirc there was some reason why it wasn't done.

@petk
Copy link
Member Author

petk commented Jul 24, 2019

Note to self: in case PHP_VERSION will be used, also phpinfo() can be adjusted to not show the extension version in such case...

@remicollet
Copy link
Member

IIRC this extension was also available on PECL
https://pecl.php.net/package/jsond

This make sense at PHP 5 time.

+1 to bump the version to PHP_VERSION

@bukka is the right guy to answer.

@bukka
Copy link
Member

bukka commented Jul 24, 2019

Yeah go for PHP_VERSION and feel free to remove it from phpinfo. As Remi said, it was because of jsond but considering that I haven't released jsond for ages and its master doesn't really follow it anyway, it just no longer makes sense to bump json ext version.

@petk
Copy link
Member Author

petk commented Jul 24, 2019

Ok, thank you all for the feedback then. Applied via dee243d commit to PHP-7.4+.

@carusogabriel
Copy link
Contributor

carusogabriel commented Oct 30, 2019

@petk Hey man, have we documented the extensions that have their versioning changed? This might help developers while upgrading their projects: lcobucci/content-negotiation-middleware#31.

@bburnichon
Copy link

I just ran into a slight issue with this version bump. I had a composer.json which requires "ext-json": "^1.2". Because of this change, I need to add "ext-json": "^1.2|^7.4", or change to the unbounded "ext-json": "*" version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants