Skip to content

Move HAVE_SQLITE3_CLOSE_V2 to pdo_sqlite #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move HAVE_SQLITE3_CLOSE_V2 to pdo_sqlite #4444

wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Jul 19, 2019

If I'm not mistaken here, this needs to be defined in pdo_sqlite's config.w32 instead of the sqlite3 extension...

cmb69
cmb69 approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this symbol is needed by ext/pdo_sqlite, not by ext/sqlite3.

@php-pulls php-pulls closed this in f5227c5 Jul 20, 2019
@petk petk deleted the patch-sqlite-unused-defs-2 branch July 20, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Category: Build System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @cmb69