Use default Autoconf configuration options checkings (bug #55634) #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building a custom macro for checking configure options, Autoconf 2.62+ outputs a warning at the beginning and the end of the output of configure script. It automatically detects correct and wrong options better. This is related also to fixing the bug #55634.
petk
force-pushed
the
patch-options-checking
branch
from
f8c6713 to
0462cbb
Compare
nikic
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building a custom macro for checking configure options, Autoconf 2.62+ outputs a warning at the beginning and the end of the output of configure script. It automatically detects correct and wrong options better.
This is related also to fixing the bug #55634.
Examples:
./configure --with-foowill output warning at the beginning and the end of the ouput./configure --foowill result in fatal error:./configure --with-foo --enable-option-checking=fatalresults in fatal error: