Remove check for ApplicationServices/ApplicationServices.h #4336
Conversation
The symbol HAVE_APPLICATIONSERVICES_APPLICATIONSERVICES_H is not used and check not needed.
|
While this isn't used in php-src, typically, this is one of those defines that subsequent included headers check for ... or used to check for ... to verify that it's not in use, you would have to look at the headers for all dependencies ... or equally, link to some piece of documentation from apple that says it's obsolete ... |
|
PHP extensions out there don't use HAVE_APPLICATIONSERVICES_APPLICATIONSERVICES_H symbol, for example. For the libraries of the macOS system, I can grep through them but also doesn't make sense to me to php-src to define this symbol. If the library needs to check for the presence of this header, then it is already done by either brew system or the mac system itself. For example, some system library, that PHP uses. This is more some unfinished step that was added without integration in the PHP code via e9111e5 |
|
I'm talking about dependencies, not extensions. It used to be the case that if you included <some/foo.h> it may ifdef for HAVE_APPLICATIONSERVICES_APPLICATIONSERVICES_H to configure itself, that's the historic use of the symbol ... |
|
Yes. Me too. If the software needs to define this symbol to be able to include the header of some library from macOS system, then the configuration header with this symbol set has also been done by that library itself... I'll grep it out, so it's more clear then... |
|
Applied to PHP-7.4 via above commit. If this will cause any issues we can add it back. So far, I haven't found any good reason to define this symbol in PHP-7.4+ and macOS or the PHP extensions out there. These also use PHP_FRAMEWORK_* macros instead... |
The symbol HAVE_APPLICATIONSERVICES_APPLICATIONSERVICES_H is not used and check not needed.