Skip to content

Refactor snmp_errors by removing a parameter which was always provided with NULL #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jun 12, 2019

Refactoring snmp_error to remove useless docref param as it was always passed NULL

@Girgias Girgias changed the base branch from master to PHP-7.4 June 12, 2019 20:46
@Girgias Girgias changed the title Refactor snmp errors to use standadizes docref Refactor snmp_errors by removing a parameter which was always provided with NULL Jun 12, 2019
@nikic
Copy link
Member

nikic commented Jun 13, 2019

It looks like SNMP is currently not tested in CI, we need a --with-snmp build somewhere.

@Girgias
Copy link
Member Author

Girgias commented Jun 13, 2019

It looks like SNMP is currently not tested in CI, we need a --with-snmp build somewhere.

Does seem like it as my first commit should have totally broke unit tests.
However, I'm worried that maybe some of the Error/Warning conditions aren't covered like the EXIF extension as seen on #4254

@nikic
Copy link
Member

nikic commented Jun 14, 2019

It looks like getting SNMP in CI is not easy. Just a --with-snmp build without running snmp server won't work.

@Girgias
Copy link
Member Author

Girgias commented Jun 14, 2019

It looks like getting SNMP in CI is not easy. Just a --with-snmp build without running snmp server won't work.

That's kind of annoying, in theory, nothing should change but well that's the theory.

Should I just leave this until something can be figured out, as my knowledge of SNMP is pretty much non-existent?

@nikic
Copy link
Member

nikic commented Jun 14, 2019

Merged as 6bd66f7. I've verified locally that it builds, which is the best I can do for now.

@nikic nikic closed this Jun 14, 2019
@Girgias Girgias deleted the refactor-snmp-docref-error branch June 14, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants