Turn add_index_zval and add_next_index_zval into inline function

[twose]

we have to code like this for a long time:

(void) add_next_index_zval(foo, bar);

and I renamed idx to index (keep the same with the others)

[cmb69]

I think it would be strange to convert add_index_zval to a macro in PHP 7.4, and to convert it back to a function in PHP 8.

[twose]

@cmb69 code like this?

#define add_index_zval(arg, index, value) \
	((void) (zend_hash_index_update(Z_ARRVAL_P(arg), index, value))

[cmb69]

@twose That would be one option. The other would be to target PHP-7.4 instead of master. The latter option would also solve microsoft/msphpsql#999.

[twose]

but macro breaks the C++ namespace and make them different from other APIs
I think this will become a historical burden

[cmb69]

So indeed targeting PHP-7.4 might be better. @dstogov what do you think?

[dstogov]

I don't see any problems.

[nikic]

I've applied the original version of this patch (macro -> inline function), as we need this on 7.4 as well. Dropping return value probably best left for master.

[mindaugasvcs]

Welcome to the dll hell!