Skip to content

ext/zip: Replace $LIBZIP_LIBDIR with $LIBZIP_LIBS #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hughmcmaster
Copy link
Contributor

No description provided.

@nikic
Copy link
Member

nikic commented Jun 4, 2019

Technically this seems "less correct", because we're going to duplicate -lzip both from the extra libs argument and the actually tested library. But I guess we don't really care anyway and this is shorter...

@hughmcmaster
Copy link
Contributor Author

hughmcmaster commented Jun 4, 2019

@nikic, That duplication would happen even if $ZIP_SHARED_LIBADD was passed in. The actual problem is that $LDFLAGS (and $LIBS) is empty when building shared extensions. If you manually set LDFLAGS, everything works as expected. But I'm struggling to work out why those variables are empty.

@nikic
Copy link
Member

nikic commented Jun 4, 2019

@hughmcmaster I believe that's because those LDFLAGS are global, while here you want to add to add extra libraries only for one extension, not all of them or the main PHP build.

@php-pulls php-pulls closed this in c9830f1 Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants