ext/ffi: Remove symbol check for ffi_open #4215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This look ok, but in this case I think we should just drop the PHP_CHECK_LIBRARY call. |
|
@nikic, Okay. Can I ask why? |
|
@hughmcmaster Unless I'm missing something here, this PHP_CHECK_LIBRARY only checks for presence of the library, which we have already ascertained from pkg-config. It does not perform a test for a conditional or version-dependent feature. |
hughmcmaster
changed the title
|
@nikic, I've updated this PR as per our discussion. And thanks for the explanation -- I now understand the rationale behind these checks a lot more now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configurefails when--with-ffi=sharedis specified and ffi is not installed in a system path, because it cannot find the ffi library.Shared builds were broken in my pull request with commit 4ffbf4e.